Add cosigner #545
Add cosigner #545
Conversation
| @@ -282,6 +282,16 @@ private bool OnInvokeCommand(string[] args) | |||
| { | |||
| var scriptHash = UInt160.Parse(args[1]); | |||
|
|
|||
| List<Cosigner> signCollection = new List<Cosigner>(); | |||
There was a problem hiding this comment.
We should be able to choose wich cosigner we want, imagine a wallet with 1.000 of address, we can't add all of them
There was a problem hiding this comment.
ｍｍｍ．I have thought about this.But generally only those exchanges will create a lot of address and they will not use this node to invoke command.
@superboyiii Can you help explain it together?
There was a problem hiding this comment.
Then with only the first one with balance it's enough?
There was a problem hiding this comment.
So we need to use manual witness first to make the pre-execution pass, calculate the contract's execution consumption, and then choose an account with a sufficient amount from the available accounts to pay the fees. Is this equal to implementing the logic about UTXO in NEO 2 again?
There was a problem hiding this comment.
I think that the user should specify which account and with which scope want to sign
There was a problem hiding this comment.
Then with only the first one with balance it's enough?
Take first one as default is dangerous,
If the contract is not source-open, it can steal asset from user easily.
I vote for the user can manually specify which account and with which scope.
But we need a method to make it easy for using
There was a problem hiding this comment.
Great proposal.I think I can implement the specified account first, the scope is a bit complicated, and in general, the scope of this invoke script should be fixed
There was a problem hiding this comment.
Maybe duplicating the methods it's easier InvokeGlobal, InvokeCalledByEntry...
There was a problem hiding this comment.
I think CalledByEntry is enough.It just a little script to invoke contract function.No other script will call this script.
There was a problem hiding this comment.
I agree @shargon , we should be able to choose co-signer.
Nowadays on Neocompiler.io we have this feature for invoking.
We are adjusting for neo3 within these next days.
neo-cli/CLI/MainService.cs
Outdated
| if (specifyAddress.Length != signCollection.Count) | ||
| { | ||
| Console.WriteLine("Error: Invalid address"); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This doesn't make sense since if I input invoke 0x0a49cc60d53a41fcf42f34632baa6ca64f987c87 deploy NPvKVTGZapmFWABLsyvfreuqn73jCjJtN1, it'll surely fail here since specifyAddress.Length will be 2.
neo-cli/CLI/MainService.cs
Outdated
| var specifyAddress = new String[args.Length - 2]; | ||
| Array.ConstrainedCopy(args, 2, specifyAddress, 0, args.Length - 2); |
There was a problem hiding this comment.
It's a hard code. I think var specifyAddress = args.Last(); is more reasonable.
neo-cli/CLI/MainService.cs
Outdated
| List<Cosigner> signCollection = new List<Cosigner>(); | ||
| using (SnapshotView snapshot = Blockchain.Singleton.GetSnapshot()) | ||
| { | ||
| UInt160[] accounts = CurrentWallet.GetAccounts().Where(p => !p.Lock && !p.WatchOnly).Select(p => p.ScriptHash).Where(p => NativeContract.GAS.BalanceOf(snapshot, p).Sign > 0).ToArray(); |
There was a problem hiding this comment.
Open wallet isn't necessary for invoking, this will cause exception.
|
I'll close this. |
Currently,in
OnInvokeCommand,we usenew cosigner[0]as a inital paramter.This will caluse falut inCheckWitness.We need to add the relevant cosigner