Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Allow to skip verification #534

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 15, 2020

@nicolegys
Copy link
Contributor

I test sync time on my private chain.
Size of Data_LevelDB:
971MB
Sync time:
verify: 446s
noverify: 434s
There's not much difference in sync time between them.
Could I know the benefits of skipping verification?

@shargon
Copy link
Member Author

shargon commented Jan 19, 2020

Could I know the benefits of skipping verification?

It's supposed to be faster, but as you said, not too much

nicolegys
nicolegys previously approved these changes Jan 20, 2020
@erikzhang
Copy link
Member

@shargon Please fix the GUI.

return value switch
{
    UInt160 i => i.ToString(),
    UInt256 i => i.ToString(),
    _ => null,
};

@shargon shargon requested a review from erikzhang January 21, 2020 09:20
@shargon shargon merged commit a477dc6 into neo-project:master Jan 21, 2020
@shargon shargon deleted the verify-import branch January 21, 2020 17:13
ShawnYun added a commit to ShawnYun/neo-node that referenced this pull request Feb 7, 2020
ZhangTao1596 pushed a commit to ZhangTao1596/neo-node that referenced this pull request Feb 10, 2020
Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Aug 18, 2021
* Add commit phase to consensus algorithm (neo-project#534)

* Add commit phase to consensus algorithm

* fix tests

* Prevent repeated sending of `Commit` messages

* RPC call gettransactionheight (neo-project#541)

* getrawtransactionheight

Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`.
Other option is to use `confirmations`, but it can be misleading.

* Minnor fix

* Shargon's tip

* modified

* Allow to use the wallet inside a RPC plugin (neo-project#536)

* Clean code

* Clean code

* Minor fix on mempoolVerified

* Add MemoryPool Unit tests. Fix bug on initital start of Persisting the Genesis block.

* Prevent `ConsensusService` from receiving messages before starting (neo-project#573)

* Prevent `ConsensusService` from receiving messages before starting

* fixed tests - calling OnStart now

* Consensus recovery log (neo-project#572)

* Pass store to `ConsensusService`

* Implement `ISerializable` in `ConsensusContext`

* Start from recovery log

* Fix unit tests due to constructor taking the store.

* Add unit tests for serializing and deserializing the consensus context.

* Combine `ConsensusContext.ChangeView()` and `ConsensusContext.Reset()`

* Add `PreparationHash` field to `PrepareResponse` to prevent replay attacks from malicious primary (neo-project#576)

* Fixed a problem where `PrepareResponse.PreparationHash` was not assigned.

* Load context from store only when height matches

* Recover nodes requesting ChangeView when possible (neo-project#579)

* Fixes bug in `OnPrepareRequestReceived()`

* Send `RecoveryMessage` only when `message.NewViewNumber <= context.ViewNumber`

* Fix and optimize view changing (#590)

* Allow to ignore the recovery logs

* Add `isRecovering` (neo-project#594)

* Fix accepting own prepare request (neo-project#596)

* Pick some changes from neo-project#575.

* Fixes `Prefixes`

* Restore transactions from saved consensus context (neo-project#598)

* Refactoring

* AggressiveInlining (neo-project#606)

* Reset Block reference when consensus context is initialized after block persist. (neo-project#608)

* Change `ConsensusPayload` for compatibility (neo-project#609)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants