Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to Script Hash Identification Change #90

Merged
merged 10 commits into from
Dec 8, 2020
Merged

Adapt to Script Hash Identification Change #90

merged 10 commits into from
Dec 8, 2020

Conversation

devhawk
Copy link
Contributor

@devhawk devhawk commented Dec 7, 2020

This PR adapts Neo Express to changes introduced by neo-project/neo#2044 (plus a few other recent changes)

  • include script hash identification in ListContractsAsync and ExpressListContracts response
  • include contract name (if available) in notify/log records + script hash and script identification in trace records
  • Rename Nep5 operations/type to Nep17
  • add --json option to several commands to produce machine readable output

@devhawk devhawk requested review from djnicholson, JohndeVadoss and a team December 7, 2020 21:50
@devhawk devhawk merged commit e70c441 into insiders Dec 8, 2020
@devhawk devhawk deleted the devhawk/no-hash-change branch December 8, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohndeVadoss JohndeVadoss JohndeVadoss approved these changes

@djnicholson djnicholson Awaiting requested review from djnicholson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devhawk @JohndeVadoss