Adjusting AVM to NEF #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Maybe after this PR we can refactor |
shargon
previously approved these changes
Jul 28, 2019
|
@shargon, what NEF means? ahauahah |
|
Neo Executable Format/File |
erikzhang
reviewed
Jul 29, 2019
erikzhang
requested changes
Jul 29, 2019
|
@lock9 I think that is done, could you test it? |
* Add header * Fix attribute
shargon
approved these changes
Sep 1, 2019
erikzhang
approved these changes
Sep 2, 2019
igormcoelho
reviewed
Sep 2, 2019
| { | ||
| Console.WriteLine(c.Key.ToString("X04") + "=>" + c.Value.ToString()); | ||
| } | ||
| } | ||
|
|
||
| private static void DumpBytes(byte[] data) | ||
| { | ||
| Console.WriteLine("AVM="); | ||
| Console.WriteLine("NEF="); |
There was a problem hiding this comment.
Isn't this suppose to be NEF3 in little-endian? Isn't this the magic?
neo-project/neo@f4adfac#diff-e18ce5ffc990682ed3c619715ebaf672R27
igormcoelho
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting #55 which was renaming to NVM, according to neo-project/neo#903