-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event name, callback support and base64 syscalls #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Jun 23, 2020
erikzhang
reviewed
Jun 23, 2020
Tommo-L
reviewed
Jun 23, 2020
I have tested notify, it's OK. Contract: public delegate void mydelegate(params object[] arg);
[DisplayName("event")]
public static event mydelegate Notify;
[DisplayName("TestEvent")]
public static event Action<byte[], BigInteger> OnEvent;
public static bool NotifyTest()
{
OnEvent(new byte[] { 0x89, 0x77, 0x20, 0xd8}, 1);
Notify("str", 11, 12);
Runtime.Log("test");
return true;
} events in abi:
Notify:
|
Tommo-L
previously approved these changes
Jun 24, 2020
16 tasks
ShawnYun
previously approved these changes
Jun 28, 2020
I found contract execute My contract: public delegate void mydelegate(params object[] arg);
[DisplayName("event")]
public static event mydelegate Notify;
private static byte[] myAddr = "NNB8GKS7mdMXXGsAwvXYyEGonkEjDbqNkG".ToScriptHash();
public static byte[] test()
{
return myAddr;
} Invoke result:
Please take a look @shargon . |
Could you take a look @lightszero ? |
erikzhang
reviewed
Jun 29, 2020
erikzhang
approved these changes
Jun 29, 2020
ShawnYun
approved these changes
Jun 30, 2020
We'd better merge it as soon as possible, so we can solve other problems which wait for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #301 #299
Require neo-project/neo#1723