Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mapping between C# types and NeoVM types #295

Merged
merged 12 commits into from
Jun 17, 2020
Merged

fix mapping between C# types and NeoVM types #295

merged 12 commits into from
Jun 17, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Jun 13, 2020 •
edited
Loading

Close #290
Wait for neo-project/neo#1701

@shargon
Copy link
Member Author

shargon commented Jun 13, 2020

Bool and tuple doesn't return the expected type.

@shargon shargon requested a review from erikzhang June 13, 2020 11:25
@erikzhang
Copy link
Member

@lightszero Can you add tuple support?

@erikzhang
Copy link
Member

Bool and tuple doesn't return the expected type.

It seems that there is no bool type in MSIL.

@shargon
Copy link
Member Author

shargon commented Jun 14, 2020 •
edited
Loading

It seems that there is no bool type in MSIL.

Yes, so we should change the issue?

True:  ldc.i4.1
False: ldc.i4.0

@erikzhang
Copy link
Member

Updated.

@lightszero
Copy link
Member

I think we support tuple => array already.
I will check that.

@shargon
Copy link
Member Author

shargon commented Jun 15, 2020

@lightszero like this it fail

var tuple = ("neo", "smart economy");
            return tuple ;

like this it works

            return  ("neo", "smart economy");

@shargon
Copy link
Member Author

shargon commented Jun 15, 2020 •
edited
Loading

float and Double works as expected but Decimal doesn't throw an unsupported instruction @lightszero

@lightszero lightszero changed the title [UT] for mapping between C# types and NeoVM types fix mapping between C# types and NeoVM types Jun 17, 2020
@lightszero lightszero mentioned this pull request Jun 17, 2020
Closed
@lightszero lightszero merged commit 3a7c670 into master Jun 17, 2020
@lightszero lightszero deleted the mapping-types-ut branch June 17, 2020 08:24
ProDog pushed a commit to ProDog/neo-devpack-dotnet that referenced this pull request Jun 22, 2020
@shargon @lightszero
@erikzhang @ProDog
fix mapping between C# types and NeoVM types (neo-project#295)
d022639 
fixed neo-project#290

Co-authored-by: lights li <lightsever@hotmail.com>
Co-authored-by: erikzhang <erik@neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapping between C# types and NeoVM types
3 participants
@shargon @erikzhang @lightszero