-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash256 and hash160, update ApplicationEngine #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProDog
reviewed
Jun 12, 2020
ProDog
reviewed
Jun 12, 2020
I have tested, it's all OK. Contract: public static object Hash160Test(byte[] msg)
{
Runtime.Notify(Crypto.RIPEMD160(msg));
Runtime.Notify(Crypto.HASH160(msg));
return Crypto.HASH160(msg);
}
public static object Hash256Test(byte[] msg)
{
Runtime.Notify(Crypto.HASH256(msg));
Runtime.Notify(Crypto.SHA256(msg));
return Crypto.HASH256(msg);
} Invoke:
Notify:
|
Tommo-L
reviewed
Jun 13, 2020
Co-authored-by: Luchuan <luchuan@ngd.neo.org>
shargon
approved these changes
Jun 15, 2020
erikzhang
approved these changes
Jun 15, 2020
Tommo-L
approved these changes
Jun 17, 2020
ProDog
pushed a commit
to ProDog/neo-devpack-dotnet
that referenced
this pull request
Jun 22, 2020
* add hash256 and hash160, update ApplicationEngine * Apply suggestions from code review Co-authored-by: Luchuan <luchuan@ngd.neo.org> * Fix UT * Clean code Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Luchuan <luchuan@ngd.neo.org> Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #288
Link neo-project/neo#1655