Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and call pointers #262

Merged
merged 14 commits into from
May 7, 2020
Merged

Create and call pointers #262

merged 14 commits into from
May 7, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Apr 30, 2020 •
edited
Loading

Require neo-project/neo-vm#317
Required for neo-project/neo#284

Also was added a DROP optimization rule

Optimized tests require #263

@shargon shargon changed the title Create callback Create callbacks Apr 30, 2020
@shargon shargon changed the title Create callbacks Create pointers May 1, 2020
@shargon shargon mentioned this pull request May 1, 2020
Merged
@shargon shargon marked this pull request as ready for review May 1, 2020 13:35
@shargon shargon changed the title Create pointers Create and call pointers May 1, 2020
@shargon shargon requested a review from lightszero May 2, 2020 09:03
lightszero
lightszero previously approved these changes May 2, 2020
View reviewed changes
@shargon
Copy link
Member Author

shargon commented May 6, 2020

We need to wait for #263

@shargon shargon requested a review from lightszero May 6, 2020 12:57
@shargon
Copy link
Member Author

shargon commented May 6, 2020

Ready to merge

@shargon shargon merged commit 63bad2a into master May 7, 2020
@shargon shargon deleted the callbacks branch May 7, 2020 07:24
@ProDog ProDog mentioned this pull request May 15, 2020
Merged
@ProDog
Copy link
Contributor

ProDog commented May 15, 2020

I have tested it.

  • The callback function runs normally without arguments.
  • An error occurred while compiling the contract, when the callback function has arguments:

image

In addition, an exception is thrown when deploy contract if CreateFuncPointer() is public:

image

@shargon
Copy link
Member Author

shargon commented May 15, 2020

Could you create a PR with the failing UT?

@ProDog
Copy link
Contributor

ProDog commented May 15, 2020

Could you create a PR with the failing UT?

I have added it #269.

@ProDog ProDog mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightszero lightszero lightszero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @ProDog @lightszero