add try-finally ut #259
Merged
add try-finally ut #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
added 2 commits
April 29, 2020 17:39
shargon
reviewed
Apr 29, 2020
lightszero
added a commit
that referenced
this pull request
May 6, 2020
* parseTryCatch * fix try endpos problem * add parse code for no catch and no finally * update trycatch * add a unittest * fix compile error on compiler * fix compiler about trycatch * fix opcodes * fix optimizer for try catch * open optimize for trycatch unittest * Fix format * fix UT (#255) * add try-finally ut (#259) * add try-finally ut * format, translate * fix try-finally and add try-catch * refactor code * keep only one try-catch matched * add commont for exception paramcount. * Update src/Neo.Compiler.MSIL/MSIL/Converter.cs * Update src/Neo.Compiler.MSIL/MSIL/Converter.cs * add try-catch failure ut (#261) * fix some skip leaves problem. * Reduce changes Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: ShawnYun <42930111+ShawnYun@users.noreply.github.com> Co-authored-by: Luchuan <luchuan@neo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lightszero Could help merge it, I have fixed the ut.