Preview4 blockchain changes #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement changes 1 and 2 from #2278
Fixes an old issue in the
neo-one/node-vmstorage implementation. TL;DR the C# version has thetableproperty it can use for indexing but since we don't have that in JS we "cheat" by just appending the table to the key and seeking off of that. This was an issue when deserializing the key for use in the newGasPerBlockRecordsstorage lookup in the NEO Native contract and was probably an issue before but since we didn't use the key AFTER seeking like this before it didn't come up.Wait to merge until #2279 is in.