Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted string-casting of file paths in GridH5ResultAdmin #252

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Reverted string-casting of file paths in GridH5ResultAdmin #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326a1a1
Reverted string-casting of file paths in GridH5ResultAdmin
benvanbasten-ns Nov 26, 2024
bcd1e23
HISTORY
benvanbasten-ns Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ History
2.3.3 (unreleased)
------------------

- Nothing changed yet.
- Reverted string-casting of file paths in GridH5ResultAdmin constructor.


2.3.2 (2024-11-26)
Expand Down
4 changes: 2 additions & 2 deletions threedigrid/admin/gridresultadmin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def __init__(self, h5_file_path, netcdf_file_path, file_modus="r", swmr=False):
:param file_modus: modus in which to open the files
"""
self._field_model_dict = defaultdict(list)
self._netcdf_file_path = str(netcdf_file_path)
super().__init__(str(h5_file_path), file_modus)
self._netcdf_file_path = netcdf_file_path
super().__init__(h5_file_path, file_modus)

self.result_datasource_class = H5pyResultGroup

Expand Down