Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix problem with slice indexing of id field #246

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix problem with slice indexing of id field #246

merged 3 commits into from
Oct 14, 2024

Conversation

jpprins1
Copy link
Contributor

@jpprins1 jpprins1 commented Oct 7, 2024 •
edited
Loading

Not 100% ideal, but it works. In the end we need to refactor the fields part to make it more robust.

@jpprins1 jpprins1 requested a review from daanvaningen October 8, 2024 07:00
daanvaningen
daanvaningen approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@daanvaningen daanvaningen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We indeed need to refactor.

I think the the addition of the composite_fields_skiP_timeseries_filter also need to be implemented on the timeseries mixins of lines and pumps right?

threedigrid/orm/base/fields.py Outdated Show resolved Hide resolved
@jpprins1 jpprins1 merged commit 98f85d5 into master Oct 14, 2024
7 checks passed
@jpprins1 jpprins1 deleted the custom_results_slice_index_fix branch October 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daanvaningen daanvaningen daanvaningen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpprins1 @daanvaningen