Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve migration performance #148

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Improve migration performance #148

merged 7 commits into from
Dec 4, 2024

Conversation

margrietpalm
Copy link
Contributor

Minor performance increase on ubuntu, but massive on windows. Execution time of full upgrade in seconds:

schematisation schema 228.1 this PR
basis_hoofdgebied_integraal 557 12
bwm_wieringermeer 1036 9
zevenaar 1668 10
supermodel_Assen_... 72 22

@margrietpalm margrietpalm requested a review from elisalle December 4, 2024 09:16
elisalle
elisalle approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only request is to add an empty newline to the end of threedi_schema/migrations/utils.py so it will not show up in git diffs.

@margrietpalm margrietpalm merged commit e38c1e9 into margriet_schema_300_leftovers Dec 4, 2024
5 checks passed
@margrietpalm margrietpalm deleted the margriet_78_improve_migration_performance branch December 4, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisalle elisalle elisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margrietpalm @elisalle