Remove leftover indices

CHANGES.rst

@@ -6,7 +6,7 @@ Changelog of threedi-schema
 0.228.1 (unreleased)
 --------------------
 
-- Nothing chaned yet
+- Remove indices referring to removed tables in previous migrations
 
 
 

threedi_schema/migrations/versions/0229_clean_up.py

@@ -6,6 +6,8 @@
 
 """
 
+from typing import List
+
 import sqlalchemy as sa
 from alembic import op
 
@@ -16,8 +18,25 @@
 depends_on = None
 
 
+def remove_tables(tables: List[str]):
+    for table in tables:
+            op.drop_table(table)
+
+
+
+def find_tables_by_pattern(pattern: str) -> List[str]:
+    connection = op.get_bind()
+    query = connection.execute(sa.text(f"select name from sqlite_master where type = 'table' and name like '{pattern}'"))
+    return [item[0] for item in query.fetchall()]
+
+
+def remove_old_tables():
+    remaining_v2_idx_tables = find_tables_by_pattern('idx_v2_%_the_geom')
+    remaining_alembic = find_tables_by_pattern('%_alembic_%_the_geom')
+    remove_tables(remaining_v2_idx_tables+remaining_alembic)
+
 def upgrade():
-    pass
+    remove_old_tables()
 
 
 def downgrade():

threedi_schema/tests/test_schema.py

@@ -219,7 +219,7 @@ def test_set_spatial_indexes(in_memory_sqlite):
             connection.execute(
                 text("SELECT DisableSpatialIndex('connection_node', 'geom')")
             ).scalar()
-            connection.execute(text("DROP TABLE idx_v2_connection_nodes_the_geom"))
+            connection.execute(text("DROP TABLE idx_connection_node_geom"))
 
     schema.set_spatial_indexes()