Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check control table values #386

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Conversation

margrietpalm
Copy link
Contributor

Check if control table values fit to expected format.

Note that this is set to be merged on the branch using schema 224 because this won't work on anything else. If this is ready before merging that branch, I'll merge this into that branch, otherwise I'll change the target to master.

@margrietpalm margrietpalm requested a review from elisalle August 15, 2024 11:29
Base automatically changed from margriet_382_schema_300_structure_control to master August 16, 2024 12:20
Copy link
Collaborator

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the regexes are correct; otherwise looks good except a small typo.

threedi_modelchecker/checks/other.py Outdated Show resolved Hide resolved
@margrietpalm margrietpalm merged commit 30be791 into master Aug 19, 2024
7 checks passed
@margrietpalm margrietpalm deleted the margriet_385_control_table_values branch August 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants