-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTMLView component for custom visualizations #404
Conversation
Does it make sense to make the naming convention similar to the IPython rich display system? Something like |
I also like the idea of marking the attribute with underscores. Would |
It might be helpful to indicate the actual type of data. Right now we only have HTML, but maybe at some point we support (pure) SVG, PNG, ... |
Hmm... I definitely like marking it with underscores. I'm kinda tempted to use exactly What about |
I like |
+1 for |
Also +1 for |
Changed! |
Given the change, I think this is ready to be merged. Speaking of which... Terry, what's the policy on merging pull requests to this repository? |
The informal policy is that I've been doing it, but for PRs that I wrote I've been waiting for someone else to mark it as "needs merge". That's mostly so that I'm the one responsible when the merges go horribly wrong. :) |
Speaking of which, this PR really needs to get rebased and tweaked to take into account the refactoring changes, even though github claims it can be merged. I think I'll wait until #491 is merged before doing that, since it's pretty close. |
In regards to the scope of this pull request, is this also supposed to make it easier for people to make their own netgraph-plot-thingy for one-off experiments? Should I open an issue in regards to that? If it is in scope, how is the user supposed to access the JavaScript/HTMLview side of things? |
Good question... I'd say that's outside the scope of this PR. This is just for making raw dumb HTML output. Things get much more complex if people what to make their own full plots. So, for example, I think this would be suitable for making the drawing of an arm used in the Spaun videos, or for making the display that shows the Ravens Matrices values (also in the Spaun videos). If people want more complex plotting abilities (like showing data over time), that involves much more javascript and is more like making your own Component. |
This lets a Node output arbitrary HTML to nengo_gui
Okay, this is now all updated with the recent refactoring. It had been previously marked as needs_merge, so I think it's all good to go, but I'll wait a day just to be sure. :) |
Yep. It's still good to go. Merge away! |
I'd be more comfortable with this being merged in if there were at least one example of it being used somewhere... |
Ooo... good idea. Okay, I've added an example as Let me know what you think... |
HTMLView component for custom visualizations
This lets a Node output arbitrary HTML to nengo_gui.
This lets you do this sort of thing:
The HTML can be anything you want, including SVG, making it possible to create visualizations of the 3-link arm, or of the Spaun brain, or of the task, anything else we want.
The basic idea is that if the output of a Node has a
.html
attribute, then you'll be able to make an HTMLView plot. After the Node is run, the value of thathtml
attribute is sent to the visualizer.