-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added memory_d>1 functionality #40
Conversation
Awesome! This will be very useful to have. The check inside of LMU that delegates to this implementation can also have the |
Thanks @NarsimhaChilkuri! Can you sign the CAA by adding yourself to this page? |
9d61854
to
7aeb03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got this fixed up and ready to go.
I had to add a has_input_kernel
option to allow turning off the input kernel in LMUFFT.delay_layer
so that test_layer_vs_cell
can pass (otherwise there was a mismatch in the number of weights). This is a feature that I figured we want anyway (a lot of our recent work uses LMUs with no dense encoding layer).
I combined the test that @NarsimhaChilkuri added into our existing test_fft
. The main difference is that it tests a few more cases. Otherwise just added a few comments and a changelog entry.
It looks like TravisCI doesn't run when it's an outside contributor branch, so I made a copy of this at origin/multi-dim-memory
. The build is running here. (EDIT: That's funny... it wouldn't start a build when I pushed to Nani's branch, but when the build passed on the copy that I pushed to origin
, Github was able to identify that a build passed on the same commit and update the check badges below.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments below, looks good overall!
OK, I've addressed your comments @drasmuss. I also noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Eric Hunsberger <eric.hunsberger@appliedbrainresearch.com>
8fa5996
to
74e9b03
Compare
LMUFFT should now be able to handle memory_d > 1, i.e, the input need not be projected down to a scalar before being fed into the delay layer.