Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [5.x] codecov #2365

Merged
merged 11 commits into from
Oct 24, 2024
Merged

ci: [5.x] codecov #2365

merged 11 commits into from
Oct 24, 2024

Conversation

DjordyKoert
Copy link
Collaborator

Adds codecov to ci

@DjordyKoert DjordyKoert changed the base branch from master to 5.x October 24, 2024 11:01
# Conflicts:
#	.github/workflows/continuous-integration.yml
@Seldaek
Copy link
Member

Seldaek commented Oct 24, 2024

I've approved codecov in the org

@DjordyKoert
Copy link
Collaborator Author

Thank you @Seldaek 😄

@DjordyKoert
Copy link
Collaborator Author

@Seldaek could you also by any chance

  1. generate a upload token and add it as a secret to the repo?
  2. or add me as a member on codecov (I think I should be able to create the token myself then)?

@Seldaek
Copy link
Member

Seldaek commented Oct 24, 2024

I can't add you without a paid plan but there is now a CODECOV_TOKEN secret available in GH Actions

Copy link

codecov bot commented Oct 24, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@DjordyKoert DjordyKoert changed the base branch from 5.x to master October 24, 2024 13:07
@DjordyKoert DjordyKoert changed the title ci: codecov ci: [5.x] codecov Oct 24, 2024
@DjordyKoert DjordyKoert changed the base branch from master to 5.x October 24, 2024 13:12
@DjordyKoert DjordyKoert marked this pull request as ready for review October 24, 2024 13:13
@DjordyKoert DjordyKoert merged commit a1c0ad1 into 5.x Oct 24, 2024
20 checks passed
@DjordyKoert DjordyKoert deleted the codecov branch October 24, 2024 13:14
DjordyKoert added a commit that referenced this pull request Oct 24, 2024
ci: [5.x] codecov (#2365)

Adds codecov to ci
@DjordyKoert DjordyKoert mentioned this pull request Oct 24, 2024
DjordyKoert added a commit that referenced this pull request Oct 24, 2024
ci: [5.x] codecov (#2365)

Adds codecov to ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants