feat(#2297): (Symfony 7.1) Add MapRequestPayload array parameter handling #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if skipping the test is correct in this case. And I noticed that I was maybe a tiny bit too early with this, since 7.1 is fairly fresh 😅 |
It is 😉
You can't start early enough, thanks a lot! |
|
I would love this to also be merged into the |
|
Thank you @mazumba :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Symfony 7.1, a new
typeparameter has been introduced forMapRequestPayloadthat allows array Controller parameters to be resolved. This currently leads to an error when the Describer tries to register a new Model, because the parameter typearrayis used in this case. To resolve the issue, the giventypeparameter form theMapRequestPayloadshould be used instead.I tried to test this as gracefully as possible. Any more elegant suggestions are welcome!