Fix state problems with main volume dial

.vscode/settings.json

@@ -22,6 +22,7 @@
   },
   "svg.preview.background": "editor",
   "cSpell.words": [
+    "ATIS",
     "Autopurge",
     "Callsign",
     "callsigns",
@@ -31,6 +32,7 @@
     "stationvolume",
     "streamdeck",
     "trackaudio",
-    "Typeguard"
+    "Typeguard",
+    "vatsim"
   ]
 }

src/controllers/mainVolume.ts

@@ -7,6 +7,9 @@ import { handleAsyncException } from "@utils/handleAsyncException";
 import { stringOrUndefined } from "@utils/utils";
 import debounce from "debounce";
 import { BaseController } from "./baseController";
+import mainLogger from "@utils/logger";
+
+const logger = mainLogger.child({ service: "mainVolumeController" });
 
 const defaultConnectedTemplatePath = "images/actions/mainVolume/template.svg";
 const defaultNotConnectedTemplatePath =
@@ -134,28 +137,52 @@ export class MainVolumeController extends BaseController {
       state: trackAudioManager.isVoiceConnected ? "connected" : "notConnected",
     };
 
-    const templatePath = trackAudioManager.isConnected
+    const templatePath = trackAudioManager.isVoiceConnected
       ? this.connectedTemplatePath
       : this.notConnectedTemplatePath;
 
     this.setFeedbackImage(templatePath, replacements);
   }
 
   private refreshTitle(): void {
-    const color = trackAudioManager.isVoiceConnected ? "white" : "grey";
+    logger.info(
+      `mainVolume refresh title, isVoiceConnected is ${
+        trackAudioManager.isConnected ? "true" : "false"
+      }`
+    );
+    if (!trackAudioManager.isVoiceConnected) {
+      this.action
+        .setFeedback({
+          title: {
+            color: "grey",
+          },
+          indicator: {
+            value: 0,
+            bar_fill_c: "grey",
+          },
+          value: {
+            value: "",
+            color: "grey",
+          },
+        })
+        .catch((error: unknown) => {
+          handleAsyncException("Unable to set dial feedback: ", error);
+        });
+      return;
+    }
 
     this.action
       .setFeedback({
         title: {
-          color: color,
+          color: "white",
         },
         indicator: {
           value: this.volume,
-          color,
+          bar_fill_c: "white",
         },
         value: {
           value: `${this.volume.toString()}%`,
-          color,
+          color: "white",
         },
       })
       .catch((error: unknown) => {

src/controllers/stationVolume.ts

@@ -256,11 +256,7 @@ export class StationVolumeController extends BaseController {
   }
 
   private refreshTitle(): void {
-    if (
-      !trackAudioManager.isConnected ||
-      !trackAudioManager.isVoiceConnected ||
-      !this.isAvailable
-    ) {
+    if (!trackAudioManager.isVoiceConnected || !this.isAvailable) {
       this.action
         .setFeedback({
           title: {

src/events/trackAudio/connected.ts

@@ -11,5 +11,4 @@ export const handleConnected = () => {
   });
 
   trackAudioManager.refreshVoiceConnectedState(); // This will force an update of station states as well if voice is connected.
-  trackAudioManager.refreshMainVolume(); // This will force an update of the main volume knobs
 };

src/events/trackAudio/mainVolumeChange.ts

@@ -20,6 +20,7 @@ export const handleMainVolumeChange = (data: MainVolumeChange) => {
 
   try {
     actionManager.getMainVolumeControllers().forEach((entry) => {
+      logger.info(`Setting mainVolume to ${data.value.volume.toString()}`);
       entry.volume = data.value.volume;
     });
   } catch (error: unknown) {

src/events/trackAudio/voiceConnectedState.ts

@@ -8,6 +8,7 @@ export const handleVoiceConnectedState = async (data: VoiceConnectedState) => {
 
   if (data.value.connected) {
     trackAudioManager.refreshStationStates();
+    trackAudioManager.refreshMainVolume(); // This will force an update of the main volume knobs
 
     // Only start polling VATSIM if there are ATIS letters.
     if (actionManager.getAtisLetterControllers().length > 0) {