-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show station volume in red when muted #386
Conversation
WalkthroughThe pull request introduces visual modifications to the Changes
Possibly related PRs
Poem
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Build for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/controllers/stationVolume.ts (1)
288-296
: LGTM! Consider extracting color values as constants.The implementation correctly shows the volume in red when muted, maintaining consistency across all UI elements (title, indicator bar, and value). The chosen red color (#a71d2a) provides good contrast for visibility.
Consider extracting the color values as named constants at the top of the file for better maintainability:
+ const MUTED_COLOR = "#a71d2a"; + const DEFAULT_COLOR = "#FFFFFF"; + const UNAVAILABLE_COLOR = "grey"; // Then in the refreshTitle method: title: { - color: this.isOutputMuted ? "#a71d2a" : "#FFFFFF", + color: this.isOutputMuted ? MUTED_COLOR : DEFAULT_COLOR, },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
com.neil-enns.trackaudio.sdPlugin/images/actions/stationVolume/template.svg
is excluded by!**/*.svg
📒 Files selected for processing (1)
src/controllers/stationVolume.ts
(1 hunks)
Fixes #385
Summary by CodeRabbit