Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generics to remove code duplication #245

Closed
neilenns opened this issue Aug 20, 2024 · 0 comments · Fixed by #246
Closed

Use generics to remove code duplication #245

neilenns opened this issue Aug 20, 2024 · 0 comments · Fixed by #246
Assignees
Labels
development Code cleanup and refactoring

Comments

@neilenns
Copy link
Owner

There's a lot of copy/paste code in the action manager class to return arrays of specific controller types. Use generics to write a general purpose getControllers function that takes a typeguard, then use that in each of the controller type functions.

@neilenns neilenns added the development Code cleanup and refactoring label Aug 20, 2024
@neilenns neilenns self-assigned this Aug 20, 2024
neilenns added a commit that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Code cleanup and refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant