-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: move chrome-aws-lambda to peer dependency #31
Comments
In my case, after a lot of trial & error, I got everything working with |
Thanks @transitive-bullshit for your research regarding this topic 🤟🏻 Your suggestion about switching these |
@neg4n from what I can tell, puppeteer-core and chrome-aws-lambda need to have the same version (or close to the same version); otherwise, the dynamic library lookup fails. What do you think about making puppeteer-core a peer dep as well? |
I think thats good idea but it needs further investigation. I've tried to do it when adding changes proposed in this issue but there were some circular deps (?) issues 👀 |
Hi, I am trying to use the suggested versions for the packages of
Do you know how it can be resolved? |
Since the most recent version of
chrome-aws-lambda
is 49.7 MB, it leaves almost no room for additional client libs in the vercel lambda.I've been running into this issue and it's really frustrating.
So my proposal is to switch
chrome-aws-lambda
to be a peer dependency and allow the user of this library to choose which chrome version they want to use.See my other comment here for the savings we're talking about: #23 (comment)
This would require also making
puppeteer-core
a peer dependency, since the two versions need to match up.The text was updated successfully, but these errors were encountered: