Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Websocket Protocol as per assetPrefix #1

Closed
wants to merge 1 commit into from

Conversation

neeraj3029
Copy link
Owner

Problem:
When the browser location protocol is https, and the assetPrefix (link to CDN) corresponds to an http protocol (like http://localhost:3000 ), the websocket protocol is still determined only by browser's location, and becomes wss://. This will lead to an incorrect websocket protocol & URL (wss://localhost:3000/, for eg.)

Changes:

This PR updates the Websocket protocol as per the assetPrefix.

Bug

@neeraj3029 neeraj3029 closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant