Removed contexts are from purge_files and don't pop from _file_map #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s API call and don't remove the filenames from _file_map so that file_id for a file remains constant over time. Modified the test for purge_files with contexts to still work, although possibly should just be removed.
|
I'd already started moving some code around in my own branch, so I'll take care of this, thanks. |
|
Great, thank you! |
|
This is finished in commit 423fa59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works for me and I agree it makes more sense to keep file_ids around so they remain constant over time for the same file. Please let me know if you would prefer just to remove the second test, which is creating contexts but not adding much anymore, other than just checking that measured_contexts() still has them (sort of obvious / unlikely to be an issue that needs to be tested here specifically).