Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paths cannot be altered by plugins #967

Closed
gaborbernat opened this issue Apr 1, 2020 · 4 comments · Fixed by #969
Closed

paths cannot be altered by plugins #967

gaborbernat opened this issue Apr 1, 2020 · 4 comments · Fixed by #969
Labels
enhancement New feature or request

Comments

@gaborbernat
Copy link
Contributor

gaborbernat commented Apr 1, 2020 •
edited
Loading

https://coverage.readthedocs.io/en/latest/config.html#paths shows how to user can set paths. This cannot be achieved by plugins due to paths not being defined as a set/get option; but rather directly as attribute on the configuration object. Due to https://github.com/nedbat/coveragepy/blob/master/coverage/control.py#L272-L276 the plugin cannot reliably access and extend this.

Came up while trying to address asottile/covdefaults#3
@gaborbernat gaborbernat added the enhancement New feature or request label Apr 1, 2020
This was referenced Apr 2, 2020
Closed
Merged
@gaborbernat
Copy link
Contributor Author

Any plans for a release anytime soon?☺️

nedbat added a commit that referenced this issue Apr 11, 2020
@nedbat
Finish up #967. Thanks, Bernát Gábor
a90fc00
@nedbat
Copy link
Owner

nedbat commented Apr 11, 2020

Fixed in edadbec.

nedbat added a commit that referenced this issue Apr 11, 2020
@nedbat
Finish up #967. Thanks, Bernát Gábor
fd43e35
@nedbat
Copy link
Owner

nedbat commented Apr 12, 2020

This is available in 5.1: https://pypi.org/project/coverage/5.1/

@gaborbernat
Copy link
Contributor Author

Thanks!

@vorpal-buildbot vorpal-buildbot mentioned this issue Apr 13, 2020
Merged
This was referenced Mar 16, 2021
Merged
Merged
This was referenced May 29, 2021
Closed
Closed
This was referenced Jun 6, 2021
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this issue Jun 18, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow plugins to alter the paths config
2 participants
@nedbat @gaborbernat