qhub upgrade custom auth plus tests #946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931 - qhub upgrade should reject custom authenticators [bug]
Changes:
qhub upgrade
will throw an error advising that custom authenticators are no longer supported.qhub upgrade --attempt-fixes
instead. This will change theqhub-config.yaml
to the basic Keycloak password authentication.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
I decided not to pollute documentation with a description of the --attempt-fixes flag since that is self-documenting - it reveals itself if it is needed, and will ideally give the user a chance to understand and think about the pros and cons first.
In pytests for test_upgrade.py, the YAML loading would ideally be a fixture, but maybe not worth changing.