Allow jupyterhub.overrides in qhub-config.yaml #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdc
reviewed
Nov 19, 2021
There was a problem hiding this comment.
LGTM, I will test this and see how that goes, thanks @danlester
costrouc
requested changes
Nov 19, 2021
There was a problem hiding this comment.
This is a great addition. @danlester could you add this to the docs?
|
Added docs, but actually I still want to test the upgraded helm chart more first. |
|
The latest Helm charts (0.10.0 onwards, including 1.2.0) have a strict networkPolicy as default. This prevented access from hub to Keycloak, and also from singleuser pods to Dask etc. It only appeared to affect Digital Ocean, not Google Cloud. This may be due to a different network system being in use. I have disabled the networkPolicy in hub and singleuser now. |
|
Also closes #926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #814
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?