Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Vale CI with GitHub Actions #871

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Enabling Vale CI with GitHub Actions #871

merged 2 commits into from
Oct 18, 2021

Conversation

HarshCasper
Copy link
Contributor

Description

Fixes #863

This PR enables Vale linter for the official documentation. It will check every PR for typos, grammar issues and make suggestions for the same.

As of now, the Vale style has been adopted with a custom vocabulary to suit out needs. It can be further refined over the time with the addition of custom styles, error messages as per our documentation needs.

The PR also fixes miscellaneous issues with the existing documentation to ensure that we can use Vale on a much more consistent basis now (without creating a lot of noise).

Local Test

  • Install Vale (brew install vale on macOS)
  • Clone the repo.
  • Checkout the PR.
  • Run Vale on specific files or directories (like docs/)

@HarshCasper HarshCasper requested a review from costrouc October 18, 2021 15:25
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great start to having better documentation. Appreciate catching the spelling mistakes.

@costrouc costrouc merged commit a5f3dde into nebari-dev:main Oct 18, 2021
@HarshCasper HarshCasper deleted the vale-ci branch October 18, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt vale for testing of docs
2 participants