fix buffer full deadlock

[Adam-D-Lewis]

Reference Issues or PRs

Fixes #2928

What does this implement/fix?

See #2928

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

How to test this PR?

Any other comments?

[Adam-D-Lewis]

This PR may still not properly handle color codes.

Update: I believe this is a separate issue.

[Adam-D-Lewis]

Also, seems like some file is not being closed correctly when looking at the error in the tests.

Update: fixed