-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure AAD/EntraID access settings #2887
base: main
Are you sure you want to change the base?
Conversation
I just need to rename the enabled field since its misleading, its intent is to enable the usage of RBAC roles from Azure instead of the default kuberntes behavior which is an authorization change, works different then the others enabled flags on nebari right now (this does not refer to the actual toggle of this property in the cluster) |
@viniciusdc is this ready for review? |
I discovered an issue with the previous Subsequently, while re-testing on a different machine (with an Azure RBAC deployment already confirmed to work), I encountered a new strange error related to the [tofu]: │ Error: Invalid index
[tofu]: │
[tofu]: │ on modules/kubernetes/outputs.tf line 4, in module "k8s_credentials":
[tofu]: │ 4: kube_admin_config = azurerm_kubernetes_cluster.main.kube_admin_config[0]
[tofu]: │
[tofu]: │ The given key does not identify an element in this collection value.
[tofu]: ╵
[tofu]: Releasing state lock. This may take a few moments... |
My assumption seems correct; after manually enabling |
Currently addressing an inconsistency with the admin kubeconfig and the exec command, while making sure that the appropriate python data object under tf_objects is correctly handled as well. The main issue, seems to be the current level of nesting associated with the credentials outputting logic, to properly handle the on/off variation of enabling RBAC we need to workaround uinsg a new child module for returning the appropriate credentials attributes later on used by the kubernetes provider, this is a bit tricky, since they change not only in naming but also in functionality. |
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Any other comments?