Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary experimental flag #2606

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Adam-D-Lewis
Copy link
Member

Reference Issues or PRs

We were using an experimental feature requiring the experiment be explicitly added, but it is no longer experimental as of version 2.6.0 release. We currently use version 2.20.0 of the kubernetes terraform provider.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Remove unneeded code

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Adam-D-Lewis

Just out of curiosity, how did you find about this? Did you run some linter or was just pure coincidence?

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Aug 1, 2024

Just out of curiosity, how did you find about this? Did you run some linter or was just pure coincidence?

I wanted to understand how the terraform state is established in stage 1, but used for all the other stages so I was digging in to understand that part of the code base and happened to see this. I suspected that this experimental feature from a while ago was likely no longer experimental. I googled around and found some references about what it did and then confirmed it was no longer in beta in the kubernetes terraform provider's changelog on github.

Thanks for reviewing!

@Adam-D-Lewis Adam-D-Lewis merged commit bb54646 into develop Aug 1, 2024
27 of 28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the remove_unnecessary_experimental_flag branch August 1, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants