Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove depracated code paths #2349

Merged
merged 2 commits into from
Mar 19, 2024
Merged

remove depracated code paths #2349

merged 2 commits into from
Mar 19, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 19, 2024

Reference Issues or PRs

We recently upgraded the min supported python version for Nebari to 3.10 so I'm removing a deprecated code path in this PR.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from dcmcand March 19, 2024 18:00
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all red diffs! Thanks @Adam-D-Lewis

@Adam-D-Lewis Adam-D-Lewis merged commit d698630 into develop Mar 19, 2024
26 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the dep_code_paths branch March 19, 2024 20:33
@viniciusdc viniciusdc added this to the 2024.3.3 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants