Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate conda-store in JupyterLab main menu #2347

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Deduplicate conda-store in JupyterLab main menu #2347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d515af
De-duplicate conda-store in JupyterLab main menu
krassowski Mar 19, 2024
1709522
Use `jupyterlab-conda-store` if available, fallback
krassowski Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ..._services/template/modules/kubernetes/services/jupyterhub/files/jupyterlab/overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"apiUrl": "/conda-store/",
"authMethod": "cookie",
"loginUrl": "/conda-store/login?next=",
"authToken": ""
"authToken": "",
"addMainMenuItem": false
},
"@jupyterlab/apputils-extension:notification": {
"checkForUpdates": false,
Expand Down Expand Up @@ -50,13 +51,8 @@
"rank": 1000,
"items": [
{
"command": "help:open",
"rank": 1,
"args": {
"url": "/conda-store",
"text": "Environment Management",
"newBrowserTab": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, does the extension still opens as a separate tab?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code was opening the /conda-store in a new browser tab.

}
"command": "condastore:open",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krassowski thanks for this, could you explain a bit how this works? does this call the extension, or the endpoint for the conda-store webpage as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It opens conda-store-ui as a tab in jupyterlab main area:

conda-store

"rank": 1
},
{
"command": "help:open",
Expand Down
Loading