Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update busybox image tag version #2167

Merged

Conversation

pt247
Copy link
Contributor

@pt247 pt247 commented Dec 22, 2023

Reference Issues or PRs

#2163

What does this implement/fix?

Deployment failures because of outdated busybox images.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Checking locally to verify the findings:

  • With: busybox:1.31

    $ docker run -it busybox:1.31 wget https://github.com/ 
    Connecting to github.com (140.82.121.3:443)
    wget: note: TLS certificate validation not implemented
    wget: TLS error from peer (alert code 80): 80
    wget: error getting response: Connection reset by peer
  • And with busybox:1.36.1:

    $ docker run -it busybox:1.36.1 wget https://github.com                   
    Connecting to github.com (140.82.121.3:443)
    wget: note: TLS certificate validation not implemented
    saving to 'index.html'
    index.html           100% |************************************************************************************|  203k  0:00:00 ETA
    'index.html' saved

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @pt247 🚀

@dcmcand dcmcand merged commit d7db557 into nebari-dev:develop Dec 22, 2023
10 checks passed
dcmcand added a commit that referenced this pull request Dec 22, 2023
Co-authored-by: Prashant Tiwari <pt247@users.noreply.github.com>
Co-authored-by: Prashant Tiwari <prashant.tiwari@genesisoilandgas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants