Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests, helm-validate script #2102

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Fix integration tests, helm-validate script #2102

merged 7 commits into from
Nov 14, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added this to the 2023.11.1 milestone Nov 9, 2023
@dcmcand dcmcand added the needs: changes 🧱 Review completed - some changes are needed before merging label Nov 11, 2023
@iameskild iameskild requested a review from dcmcand November 14, 2023 02:16
@iameskild iameskild merged commit b9158e4 into develop Nov 14, 2023
29 checks passed
@iameskild iameskild deleted the 20231108eae branch November 14, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcmcand dcmcand dcmcand approved these changes

Assignees
No one assigned
Labels
area: CI/CD 👷🏽‍♀️ area:developer-experience 👩🏻‍💻 needs: changes 🧱 Review completed - some changes are needed before merging type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@iameskild @dcmcand