Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: use packaging for version parsing, add unit tests #2048

Merged
merged 3 commits into from
Nov 8, 2023
Merged

ENH: use packaging for version parsing, add unit tests #2048

merged 3 commits into from
Nov 8, 2023

Conversation

fangchenli
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Use packaging for version parsing in upgrade. Also added unit tests for validation while creating subclasses of UpgradeStep.

@fangchenli fangchenli added area: dependencies 📦 All things dependencies type:extension Nebari Extension labels Oct 3, 2023
@fangchenli fangchenli marked this pull request as draft October 6, 2023 05:41
@fangchenli fangchenli marked this pull request as ready for review October 17, 2023 03:20
@iameskild iameskild added this to the The Release After Next milestone Oct 18, 2023
iameskild
iameskild approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iameskild iameskild merged commit 1f4891f into nebari-dev:develop Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦 All things dependencies type:extension Nebari Extension
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @iameskild