Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: fix most typing errors in provider #2038

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

fangchenli
Copy link
Member

Reference Issues or PRs

xref #1800

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

fangchenli referenced this pull request Sep 28, 2023
…ssed through (#1921)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging all of this type checking! Are you using any special type checker to uncover these?

@fangchenli
Copy link
Member Author

Thanks for digging all of this type checking! Are you using any special type checker to uncover these?

Those are discovered by mypy. I will add mypy check to CI after all typing errors are fixed.

@iameskild iameskild merged commit 1686693 into nebari-dev:develop Oct 13, 2023
@fangchenli fangchenli deleted the typing-provider branch October 22, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants