Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinup spot instance for CI with cirun #1882

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Spinup spot instance for CI with cirun #1882

merged 2 commits into from
Aug 2, 2023

Conversation

aktech
Copy link
Member

@aktech aktech commented Aug 2, 2023

This would first try to spinup spot instance and if that fails then will spinup on-demand instance.

To save CI costs this would first try to spinup spot instance first and if that fails then will spinup on-demand instance.
See https://docs.cirun.io/reference/fallback-runners#example-3-preemptiblenon-preemptible-instances

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

aktech added 2 commits August 2, 2023 12:33
This would first try to spinup spot instance and if that fails then will spinup on-demand instance.
@aktech aktech requested a review from a team August 2, 2023 11:41
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @aktech

@costrouc costrouc merged commit c538b3e into develop Aug 2, 2023
@costrouc costrouc deleted the cirun-preemptible branch August 2, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants