support deploying on existing vpc on aws #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-D-Lewis
commented
May 17, 2023
Adam-D-Lewis
commented
May 17, 2023
Adam-D-Lewis
commented
May 17, 2023
| **config.get("aws", {}).get("terraform_overrides", {}), | ||
| **config.get("amazon_web_services", {}).get("terraform_overrides", {}), |
There was a problem hiding this comment.
These terraform overrides were not usable before as far as I can tell. You'd get an error from pydantic that extra fields (the aws field) weren't allowed when I added an aws section to the nebari-config.yaml.
There was a problem hiding this comment.
Now they can be used via (e.g.)
amazon_web_services:
terraform_overrides:
existing_subnet_ids: ["subnet-05b2b1f41f0b1d8a6", "subnet-017efc3309fbca2da"]
existing_security_group_id: "sg-0e2c865bdd8824b1a"
region: ...
<other_attributes>: ...
There was a problem hiding this comment.
Is it worth formalizing these the available terraform_overrides in the schema?
Adam-D-Lewis
commented
May 17, 2023
iameskild
reviewed
May 18, 2023
There was a problem hiding this comment.
@Adam-D-Lewis I had a few questions. This looks like a worthwhile addition :)
| **config.get("aws", {}).get("terraform_overrides", {}), | ||
| **config.get("amazon_web_services", {}).get("terraform_overrides", {}), |
There was a problem hiding this comment.
Is it worth formalizing these the available terraform_overrides in the schema?
iameskild
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?