Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set /etc/hosts #1728

Closed
wants to merge 1 commit into from
Closed

don't set /etc/hosts #1728

wants to merge 1 commit into from

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Apr 14, 2023

What does this implement/fix?

There are basically two scenarios:

  1. We have domain and can set the DNS. In that case there is no need to set /etc/hosts since the DNS is handling it for us
  2. We don't have a domain. In that case setting /etc/hosts is not enough. See [BUG] - Installing nebari locally (local with kind) fails. #1703 (comment) and [BUG] - local deploy cannot guaranteed be done without having access to a domain #1707.

Thus, there is no need to set it at all. This PR removes it from CI to see if anything breaks (it shouldn't). If we move forward here, we also need to send a PR to the docs and remove that section there.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@pmeier
Copy link
Member Author

pmeier commented Apr 14, 2023

Closing this since the k8s tests are not run from forks:

test-kubernetes:
if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name != 'pull_request'

@pmeier pmeier closed this Apr 14, 2023
@pmeier pmeier deleted the etc-hosts branch May 24, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant