Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --quiet flag for conda install in CI #1699

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Use --quiet flag for conda install in CI #1699

merged 1 commit into from
Apr 13, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Apr 7, 2023

Per title. Although we definitely want verbose output in CI, --quiet is actually harmless:

$ conda install --help | grep -e '--quiet'
  -q, --quiet           Do not display progress bar.

So this just disables just the progress bars, which create quite a few unnecessary lines. For example: https://github.com/nebari-dev/nebari/actions/runs/4621921970/jobs/8173947067#step:4:646

@pavithraes pavithraes added the type: maintenance 🛠 Day-to-day maintenance tasks label Apr 12, 2023
@pavithraes pavithraes added the needs: review 👀 This PR is complete and ready for reviewing label Apr 12, 2023
viniciusdc
viniciusdc approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Thanks @pmeier

@pmeier pmeier merged commit 9915a6d into nebari-dev:develop Apr 13, 2023
@pmeier pmeier deleted the conda-install-quiet branch April 13, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

@iameskild iameskild Awaiting requested review from iameskild

Assignees

@pmeier pmeier

Labels
needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @viniciusdc @pavithraes