Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples folder #1664

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

ppwadhwa
Copy link
Contributor

Reference Issues or PRs

Now that examples are on the repo, we no longer need the shared/examples folder.

This is mentioned here: #1558 (comment)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@kcpevey kcpevey requested a review from iameskild March 9, 2023 15:39
@iameskild iameskild added this to the Release 2023.3.1 milestone Mar 14, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppwadhwa! LGTM :)

@trallard
Copy link
Member

Is this ready for merge? If so can you please add the corresponding label and merge? cc @iameskild @ppwadhwa

@iameskild iameskild added area: user experience 👩🏻‍💻 status: approved 💪🏾 This PR has been reviewed and approved for merge labels Mar 14, 2023
@iameskild iameskild merged commit 6ca5f1a into nebari-dev:develop Mar 14, 2023
@ppwadhwa ppwadhwa deleted the remove_example_folder branch March 21, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
Development

Successfully merging this pull request may close these issues.

3 participants