Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Raise timeout for jupyter session #1646

Merged

Conversation

ppwadhwa
Copy link
Contributor

@ppwadhwa ppwadhwa commented Feb 9, 2023

This PR raises the timeout length for a jupyter session. I believe it changed it the right place. Please let me know if there is another place.

Reference Issues or PRs

fixes #1615

#1615

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • [x ] Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added this to the Release 2023.2.1 milestone Feb 9, 2023
@kcpevey
Copy link
Contributor

kcpevey commented Feb 13, 2023

This raises the timeout for the jupyter session, but the issue is around raising the timeout for the jupyter terminal session. A slight, but important, nuance.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this will make @dharhas happy ;)

@iameskild
Copy link
Member

/bot run tests

@iameskild
Copy link
Member

I'm not sure why the /bot run tests command isn't working but I'm confident this PR would pass the tests that have been skipped.

@iameskild iameskild merged commit 3f74268 into nebari-dev:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Increase idle timeout for JupyterLab Terminal
3 participants