Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin packages in default dashboard env #1628

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Unpin packages in default dashboard env #1628

merged 1 commit into from
Jan 31, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Fixes #1617

What does this implement/fix?

This simply unpins the packages used by the default nebari-git/dashboard environment. It was originally pinned because the solve was taking a long time but with the switch to using mamba to build these environments, that hasn't been an issue. Our other default environment nebari-git/dask already has it's packages unpinned.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks area: dependencies 📦 All things dependencies labels Jan 28, 2023
@iameskild iameskild mentioned this pull request Jan 28, 2023
11 tasks
@iameskild iameskild added this to the Release 2023.1.1 milestone Jan 28, 2023
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think these should be left unpinned. That said, Pam and I have been working on updating the dashboard examples which is also requiring an update to this environment. So, I'm approving this to get this bug fixed, but I'll follow up with a PR which will make improvements on it (not to be included in this release).

@iameskild iameskild merged commit 3d0c97f into develop Jan 31, 2023
@iameskild iameskild deleted the fix-1617 branch January 31, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Shipped dashboard env doesn't work with streamlit
2 participants