Adding jupyterlab-conda-store extension support to Nebari #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR depends on nebari-dev/nebari-docker-images#41 being merged. Additionally fixes an unupdated section where we specified an older conda-store version. We override the conda-store url in the jupyterlab settings overrides.
|
This PR requires using the jupyterlab image from nebari-dev/nebari-docker-images#41. I have not tested this yet. Will once other is merged. |
iameskild
approved these changes
Nov 29, 2022
| @@ -36,7 +36,7 @@ variable "conda-store-image" { | |||
| variable "conda-store-image-tag" { | |||
| description = "Version of conda-store to use" | |||
| type = string | |||
| default = "v0.4.9" | |||
| default = "v0.4.12" | |||
There was a problem hiding this comment.
Yeup I saw that it had been updated in constants. Not sure if we should even have a default value here then?
|
@costrouc @iameskild Shall we merge this PR? |
|
@pavithraes this PR can't be merged until nebari-dev/nebari-docker-images#45 is merged in docker-images. @iameskild would you be fine with the jupyterlab extension fitting into the December release? |
|
@costrouc the docker-image PR has been approved and merged :) |
1 task
|
@costrouc @iameskild We decided to not have a release this week, but should we still merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on
nebari-dev/nebari-docker-images#41 being merged.
Additionally fixes an unupdated section where we specified an older conda-store version.
We override the conda-store url in the jupyterlab settings overrides.
Reference Issues or PRs
What does this implement/fix?