Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Spinup unique cirun runners for each job #1563

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

aktech
Copy link
Member

@aktech aktech commented Nov 22, 2022

Sometimes it happens, when a runner is created for a job, it gets consumed by a job queued earlier, causing confusion sometimes. This PR makes sure, the runner is only consumed by the job it was created by. It's cirun's new feature, read more here: https://docs.cirun.io/reference/unique-runner-labels

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech force-pushed the cirun-unique-runners branch from 0ba8c5e to a5b7002 Compare November 22, 2022 12:44
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iameskild iameskild changed the base branch from main to release/2022.11.1 November 24, 2022 00:47
@aktech aktech force-pushed the cirun-unique-runners branch from 0cc5827 to 4380083 Compare November 24, 2022 08:14
@aktech aktech merged commit bd777e6 into release/2022.11.1 Nov 24, 2022
@aktech aktech deleted the cirun-unique-runners branch November 24, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants