-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-1417: Improve Dask workers placement on AWS | fixing a minor typo #1487
Issue-1417: Improve Dask workers placement on AWS | fixing a minor typo #1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @limacarvalho! Thank you for your contribution :)
Some of the CI tests will fail because this PR is coming from a fork (an issue we are aware of) however would you mind running pre-commit
on these files?
…kers-to-run-on-AWS-EKS-specific-nodegroups
Hi there, just chiming in to say I'm also hitting the same issue with nebary 2022.10.1 on GCP not being able to place worker and scheduler pods into specific node groups, and would love to see this fix get merged! Kudos @limacarvalho for bottoming this one out 🙏 |
…orkers-to-run-on-AWS-EKS-specific-nodegroups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@limacarvalho @alimanfoo I apologize for the delay! We very much appreciate this bug fix and will make sure we get around to reviewing and merging this incoming PRs more quickly next time around! :)
Fixes | Closes | Resolves #
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.