Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1417: Improve Dask workers placement on AWS | fixing a minor typo #1487

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Issue-1417: Improve Dask workers placement on AWS | fixing a minor typo #1487

merged 4 commits into from
Nov 30, 2022

Conversation

limacarvalho
Copy link
Contributor

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @limacarvalho! Thank you for your contribution :)

Some of the CI tests will fail because this PR is coming from a fork (an issue we are aware of) however would you mind running pre-commit on these files?

@alimanfoo
Copy link
Contributor

Hi there, just chiming in to say I'm also hitting the same issue with nebary 2022.10.1 on GCP not being able to place worker and scheduler pods into specific node groups, and would love to see this fix get merged! Kudos @limacarvalho for bottoming this one out 🙏

@iameskild iameskild changed the base branch from main to release/2022.11.1 November 28, 2022 10:39
…orkers-to-run-on-AWS-EKS-specific-nodegroups
@iameskild iameskild added this to the Release 2022.11.1 milestone Nov 28, 2022
@iameskild iameskild added type: bug 🐛 Something isn't working area: integration/Dask Issues related to Dask on QHub labels Nov 29, 2022
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@limacarvalho @alimanfoo I apologize for the delay! We very much appreciate this bug fix and will make sure we get around to reviewing and merging this incoming PRs more quickly next time around! :)

@iameskild iameskild merged commit 1f079a4 into nebari-dev:release/2022.11.1 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Dask Issues related to Dask on QHub type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Unable to force Dask workers to run on AWS EKS specific nodegroups
3 participants