Adding option to supply additional arguments to ingress via ingress.terraform_overrides.additional-arguments
#1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingress.terraform_overrides.additional-arguments: [...] See https://doc.traefik.io/traefik/reference/static-configuration/cli/
65b4a7d to
f64dcc7
Compare
|
For tomorrow I think the cli option we are looking to use is |
iameskild
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
To confirm, this section here will unpack the ingress.terraform_overrides and so long as the values for additional-arguments (<-- typed with a - and not _) are passed as a list, this should just work as is.
The above was mostly for me but if I've misunderstood, let me know. Otherwise, this looks great :)
|
@iameskild that is right. Longer term I think it makes sense to centralize these options so that terraform_overrides can be supplied to any stage. Yes an example would be ingress:
terraform_overrides:
additional-arguments:
- "--entryPoints.websecure.forwardedHeaders.insecure" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ingress.terraform_overrides.additional-arguments: [...]
See https://doc.traefik.io/traefik/reference/static-configuration/cli/